Fix LHN displays "...owes 0.00" when user receives split request message#46166
Conversation
Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>
Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>
Reviewer Checklist
Screenshots/VideosAndroid: Native46166_android_native.movAndroid: mWeb Chrome46166_android_mweb.moviOS: Native46166_ios_native.moviOS: mWeb Safari46166_ios_mweb.movMacOS: Chrome / Safari46166_web_chorme.movMacOS: Desktop46166_desktop.mov |
neil-marcellini
left a comment
There was a problem hiding this comment.
Looks great, thank you! I left some NABs that could be done in a follow up.
| if (!report?.reportID) { | ||
| return; | ||
| } | ||
| const lastAction = visibleReportActionItems[report.reportID]; |
There was a problem hiding this comment.
NAB: Can we rename visibleReportActionItems to lastVisibleReportActions? Not a blocker since it's been named that way for a while. You can create a follow up PR for this and tag me for review.
| /** Array of report actions for this report */ | ||
| reportActions: OnyxEntry<ReportActions>; | ||
|
|
||
| /** Array of report actions of IOU report related to this report last action */ |
There was a problem hiding this comment.
NAB: Could you please explain more about why this is needed, so that data displayed in the option item is updated when a new action is pushed, such as display the split amount owed?
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.0.14-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.14-6 🚀
|
Details
Fixed Issues
$ #45855
PROPOSAL: #45855 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android-native-d.mp4
Android: mWeb Chrome
android-mweb_d.mp4
iOS: Native
ios-native_d.mp4
iOS: mWeb Safari
ios-msfari_d.mp4
MacOS: Chrome / Safari
macos-web-d.mp4
MacOS: Desktop
macos-desktop_d.mp4